Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix packet commitment path used for timeout #7646

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Dec 9, 2024

Description

test for this already existed, it passed because it too used the wrong channel identifier.

closes: #7643


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

sonarqubecloud bot commented Dec 9, 2024

Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Did you confirm that both sides have different channel IDs?

@DimitrisJim
Copy link
Contributor Author

Nice! Did you confirm that both sides have different channel IDs?

Yea, they do! Changing it to correct value made test fail (i.e test was written wrong too!)

@DimitrisJim DimitrisJim merged commit cd2e4fa into feat/ibc-eureka Dec 9, 2024
66 checks passed
@DimitrisJim DimitrisJim deleted the jim/timeout-verify-dest branch December 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants