Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do validation checks before processing the packet in 04 channel v2 #7637

Conversation

gjermundgaraba
Copy link
Contributor

Description

closes: #7636

It was also mentioned during the audit that this should also be done for timeout, but I guess the moving the Route loop earlier would make trouble in the no-op case? If there are some other cases here I should cover, let me know and I will add it to the PR.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@gjermundgaraba gjermundgaraba changed the base branch from main to feat/ibc-eureka December 7, 2024 21:19
Copy link

sonarqubecloud bot commented Dec 7, 2024

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
66.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any validation in TimeoutPacket that can be moved before core handler is actually called.

@gjermundgaraba gjermundgaraba merged commit 4c6b84a into feat/ibc-eureka Dec 10, 2024
72 of 73 checks passed
@gjermundgaraba gjermundgaraba deleted the gjermund/7636-do-validation-checks-before-processing-the-packet-in-04-channel-v2 branch December 10, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do validation checks before processing the packet in 04-channel V2
3 participants