Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: document channel id requirements for packet commitment keys #7633

Merged
merged 1 commit into from
Dec 10, 2024
Merged

chore: document channel id requirements for packet commitment keys #7633

merged 1 commit into from
Dec 10, 2024

Conversation

gjermundgaraba
Copy link
Contributor

Description

closes: #7632

I also moved the packet commitment prefix functions to 24-host to not have multiple implementations floating around (and where they will be under unit tests).

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2024

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gjermundgaraba gjermundgaraba merged commit 96bdd56 into feat/ibc-eureka Dec 10, 2024
66 checks passed
@gjermundgaraba gjermundgaraba deleted the gjermund/7632-document-channel-id-requirements-for-packet-commitment-keys branch December 10, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaSripal AdityaSripal AdityaSripal approved these changes

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@DimitrisJim DimitrisJim Awaiting requested review from DimitrisJim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjermundgaraba @AdityaSripal