Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add channel consensus state rpc #7619

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Dec 4, 2024

Description

Note, we don't have a cli for this in main so didn't add one here. Can add it if needed (assume it doesn't exist in main for a reason)

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim DimitrisJim force-pushed the jim/channel-consensus-state-grpc branch 5 times, most recently from 692e186 to 8d437a9 Compare December 10, 2024 09:42
@DimitrisJim DimitrisJim force-pushed the jim/channel-consensus-state-grpc branch 3 times, most recently from d715998 to 78fc6c8 Compare December 11, 2024 10:21
@DimitrisJim DimitrisJim marked this pull request as ready for review December 11, 2024 10:22
@DimitrisJim DimitrisJim force-pushed the jim/channel-consensus-state-grpc branch from 78fc6c8 to a02b5e6 Compare December 12, 2024 08:01
@AdityaSripal
Copy link
Member

Maybe a stupid question since all queries seem to have this. But why have proof in the response if it is always nil? I understand proof is not retreivable from within the state machine. Will it be filled through a different gateway?

@damiannolan
Copy link
Member

Agree we normally put it in our msgs because we offered some CLIs which short-circuited grpc by hitting abci directly - in those cases we fulfil proof and proofHeight. But if we don't offer that kind of CLI here then don't see the point in putting it in the proto msg. You can still query abci directly and get a proof back for it.

One thing to consider is that other consumers of the protobuf messages treat them as canonical apis for different runtime envs (e.g. penumbra etc)... not sure how that affects decision making here tho..

@DimitrisJim
Copy link
Contributor Author

DimitrisJim commented Dec 16, 2024

One thing to consider is that other consumers of the protobuf messages treat them as canonical apis for different runtime envs (e.g. penumbra etc)... not sure how that affects decision making here tho..

think this is good enough justification for now to keep things as is for time being (and as we historically did). Maybe its a point to be raised with other teams/consumers of proto defs though and possibly rm'ing them after that is resolved.

@DimitrisJim DimitrisJim force-pushed the jim/channel-consensus-state-grpc branch from a02b5e6 to e289f00 Compare December 16, 2024 11:00
Copy link

@DimitrisJim DimitrisJim merged commit a5b69ec into feat/ibc-eureka Dec 16, 2024
67 checks passed
@DimitrisJim DimitrisJim deleted the jim/channel-consensus-state-grpc branch December 16, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants