Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add channel client state rpc #7616

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Dec 3, 2024

Description

ref: #7478


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim DimitrisJim force-pushed the jim/channel-client-state-grpc branch 2 times, most recently from 2b5f40b to 0660444 Compare December 4, 2024 03:44
@DimitrisJim DimitrisJim force-pushed the jim/channel-client-state-grpc branch from 0660444 to 8f28494 Compare December 5, 2024 02:20
@DimitrisJim DimitrisJim marked this pull request as ready for review December 5, 2024 02:20
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is beautifully clean, just left one comment about providing proofs from here

modules/core/04-channel/v2/client/cli/query.go Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Dec 6, 2024

@DimitrisJim DimitrisJim merged commit 82348c6 into feat/ibc-eureka Dec 6, 2024
67 checks passed
@DimitrisJim DimitrisJim deleted the jim/channel-client-state-grpc branch December 6, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants