Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: added simpler events #7613

Merged
merged 8 commits into from
Dec 3, 2024
Merged

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Dec 2, 2024

Description

closes: #7607, #7608, #7386


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

sonarqubecloud bot commented Dec 2, 2024

@DimitrisJim DimitrisJim mentioned this pull request Dec 2, 2024
10 tasks
Comment on lines +19 to +22
encodedPacket, err := proto.Marshal(&packet)
if err != nil {
panic(err)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When event emission is changed to env event service this func will be a method on Keeper. Will have access to codec on method recvr then instead of plumbing it through now and can just use k.cdc.MustMarshal(packet)

I can create an issue. I don't want to block on this going through

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srdtrk srdtrk merged commit 3864793 into feat/ibc-eureka Dec 3, 2024
65 checks passed
@srdtrk srdtrk deleted the serdar/7607-simple-events branch December 3, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants