refactor: update icahost to use runtime.Environment #7600
Conversation
…authKeeper where apt
| if res == nil || res.Value == nil { | ||
|
|
||
| if err := m.cdc.Unmarshal(query.Data, msg); err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
I think it might be best to return a more "constant" error here if this rpc is intended to be run in OnRecvPacket. Protobuf unmarshalling errors have a possibility to be indeterminate (this was a something found in earlier days of ibc transfer).
cc. @AdityaSripal this is correct, right?
There was a problem hiding this comment.
Actually, I think this is protected by the fact that we changed acknowledgement errors themselves to strip out abci error code alone. But none the less, this is something good to be aware of cc. @gjermundgaraba
There was a problem hiding this comment.
for example, back in the day we used to do this https://github.com/cosmos/ibc-go/blob/v3.4.0/modules/apps/transfer/ibc_module.go#L177 and it was for that reason.
There was a problem hiding this comment.
ah yea, great point to raise.
…ry request data fails
| if res == nil || res.Value == nil { | ||
|
|
||
| if err := m.cdc.Unmarshal(query.Data, msg); err != nil { | ||
| return nil, errorsmod.Wrapf(ibcerrors.ErrInvalidType, "cannot unmarshal query request data to: %s", md.Input().FullName()) |
There was a problem hiding this comment.
lemme know if you wanna use ibcerrors.ErrInvalidRequest instead here...
There was a problem hiding this comment.
I'm pretty agnostic. They both seem OK
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -2,13 +2,15 @@ | |||
|
|
|||
| import ( | |||
| "context" | |||
| "fmt" | |||
| "reflect" | |||
Check notice
Code scanning / CodeQL
Sensitive package import Note
| if res == nil || res.Value == nil { | ||
|
|
||
| if err := m.cdc.Unmarshal(query.Data, msg); err != nil { | ||
| return nil, errorsmod.Wrapf(ibcerrors.ErrInvalidType, "cannot unmarshal query request data to: %s", md.Input().FullName()) |
There was a problem hiding this comment.
I'm pretty agnostic. They both seem OK
| func (m msgServer) ModuleQuerySafe(goCtx context.Context, msg *types.MsgModuleQuerySafe) (*types.MsgModuleQuerySafeResponse, error) { | ||
| ctx := sdk.UnwrapSDKContext(goCtx) | ||
|
|
||
| func (m msgServer) ModuleQuerySafe(ctx context.Context, msg *types.MsgModuleQuerySafe) (*types.MsgModuleQuerySafeResponse, error) { |
There was a problem hiding this comment.
what do you think @srdtrk? 😄
|
Description
Updates icahost submodule to use
runtime.Environment.Removes
storeService,msgRouterServiceandqueryRouterServicein favour of embeddedappmodule.Environment.ref: #7712
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.