Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add packet acknowledgements rpc #7558

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Nov 13, 2024

Description

ref: #7478


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim DimitrisJim marked this pull request as draft November 13, 2024 09:56
@DimitrisJim DimitrisJim force-pushed the jim/packet-acks-rpc branch 3 times, most recently from 712a1d6 to 24ea202 Compare November 13, 2024 12:24
@DimitrisJim DimitrisJim marked this pull request as ready for review November 13, 2024 12:24
@DimitrisJim DimitrisJim force-pushed the jim/packet-acks-rpc branch 2 times, most recently from 999deab to b46128b Compare November 21, 2024 09:14
Copy link

sonarqubecloud bot commented Dec 2, 2024

@DimitrisJim DimitrisJim merged commit d894684 into feat/ibc-eureka Dec 2, 2024
66 checks passed
@DimitrisJim DimitrisJim deleted the jim/packet-acks-rpc branch December 2, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants