Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (api)!: remove capabilities from WriteAcknowledgement #7225

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

bznein
Copy link
Contributor

@bznein bznein commented Aug 29, 2024

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@bznein bznein added the priority PRs that need prompt reviews label Aug 29, 2024
@bznein bznein marked this pull request as ready for review August 29, 2024 10:47
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can add changelog for these in each PR and just do docs all together at end?

Either way, lgtm! Love seeing these PRs land!

@bznein
Copy link
Contributor Author

bznein commented Aug 29, 2024

I guess we can add changelog for these in each PR and just do docs all together at end?

Either way, lgtm! Love seeing these PRs land!

Yeah I'll add the changelog and add a placeholder as Carlos did for the SendPacket

Copy link

@bznein bznein added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit d771177 Aug 29, 2024
73 checks passed
@bznein bznein deleted the bznein/removeCaps/WriteAck branch August 29, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants