Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add helper to retrieve handler and module based on protocol version #7198

Merged
merged 4 commits into from
Aug 26, 2024
Merged

add helper to retrieve handler and module based on protocol version #7198

merged 4 commits into from
Aug 26, 2024

Conversation

chandiniv1
Copy link
Contributor

closes: #7119

crodriguezvega
crodriguezvega approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some changes, so it looks good to me now. This code might change again in the next weeks, but I think for now this is good enough. Thanks!

@chandiniv1 chandiniv1 requested a review from DimitrisJim August 22, 2024 09:55
DimitrisJim
DimitrisJim approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some minor tweaks to first case, thanks! will merge after tests/ci go green!

@DimitrisJim DimitrisJim merged commit e66223c into cosmos:feat/ibc-eureka Aug 26, 2024
25 checks passed
@DimitrisJim DimitrisJim mentioned this pull request Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@chatton chatton Awaiting requested review from chatton

Assignees
No one assigned
Labels
feat: ibc-eureka
Projects
IBC-GO Eureka
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chandiniv1 @crodriguezvega @DimitrisJim