Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: msg server tests for eureka #7162

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

colin-axner
Copy link
Contributor

Description

closes: #7106


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@AdityaSripal AdityaSripal self-assigned this Aug 20, 2024
@AdityaSripal AdityaSripal marked this pull request as ready for review August 20, 2024 12:29
@AdityaSripal
Copy link
Member

I just ported over the v1 tests and converted them to make the same v2 tests.

Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving even though I did converted of the tests here

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, checked the cov locally and only switch default case in not covered. I added that as a panic which, in hindsight, probably can be an error considering sdk will convert panic into error either way.

Copy link

@crodriguezvega crodriguezvega merged commit ad5748e into feat/ibc-eureka Aug 22, 2024
64 of 65 checks passed
@crodriguezvega crodriguezvega deleted the colin/7106-msg-server-tests-eureka branch August 22, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants