-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: msg server tests for eureka #7162
tests: msg server tests for eureka #7162
Conversation
…/7106-msg-server-tests-eureka
I just ported over the v1 tests and converted them to make the same v2 tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving even though I did converted of the tests here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, checked the cov locally and only switch default case in not covered. I added that as a panic which, in hindsight, probably can be an error considering sdk will convert panic into error either way.
Quality Gate passed for 'ibc-go'Issues Measures |
Description
closes: #7106
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.