Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: add tests for BuildMerklePath, make merkle path non-nullable in counterparty #7160

Merged
merged 3 commits into from
Aug 18, 2024

Conversation

colin-axner
Copy link
Contributor

Description

closes: #7121
closes: #7159


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

expPath: commitmenttypesv2.NewMerklePath(packetCommitmentKey),
},
{
name: "empty path",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test fails because BuildMerklePath modifies the underlying slice elements, so despite returning a merkle path, it is also modifying the prefix passed in which might have unintentional side affects. I'm going to rework the code to avoid modifying the underlying slice of prefix

Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!

Copy link

@crodriguezvega crodriguezvega merged commit 0a9b799 into feat/ibc-eureka Aug 18, 2024
63 of 65 checks passed
@crodriguezvega crodriguezvega deleted the colin/7121-buildmerklepath-test branch August 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants