Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary comments #7155

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

colin-axner
Copy link
Contributor

Description

closes: #7151


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@@ -152,8 +152,6 @@ func (k Keeper) RecvPacket(
return "", channeltypes.ErrNoOpMsg
}

// create key/value pair for proof verification by appending the ICS24 path to the last element of the counterparty merklepath
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't feel like this comment added much value

@@ -152,8 +152,6 @@ func (k Keeper) RecvPacket(
return "", channeltypes.ErrNoOpMsg
}

// create key/value pair for proof verification by appending the ICS24 path to the last element of the counterparty merklepath
// TODO: allow for custom prefix
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This todo is already addressed by prefixing being in the counterparty? What does "custom prefix" mean otherwise?

Copy link

@crodriguezvega crodriguezvega merged commit eb2830f into feat/ibc-eureka Aug 15, 2024
63 of 65 checks passed
@crodriguezvega crodriguezvega deleted the colin/7151-customprefix-todo branch August 15, 2024 13:00
@crodriguezvega crodriguezvega mentioned this pull request Aug 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants