feat(eureka): Add gRPC query for Counterparty for a given client identifier #7120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! is there additional work needed here before making this ready for review? |
vishal-kanna
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
crodriguezvega
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
I contributed to the PR, but giving me approval. Thanks, @vishal-kanna!
DimitrisJim
reviewed
Aug 26, 2024
|
|
||
| sdkCtx := sdk.UnwrapSDKContext(ctx) | ||
| creator, found := q.GetCreator(sdkCtx, req.ClientId) | ||
| if found { |
There was a problem hiding this comment.
are these needed? we get a default of "" either way?
proto/ibc/core/client/v1/query.proto
Outdated
| // QueryClientRequest is the response type for the Query/Client RPC method | ||
| message QueryClientResponse { | ||
| string creator = 1; | ||
| Counterparty counterparty = 2; |
| testCases := []struct { | ||
| msg string | ||
| malleate func() | ||
| errMsg string |
There was a problem hiding this comment.
can we go with the expError pattern instead?
|
cleaning these up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #7116