Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eureka): add CLI to submit MsgProvideCounterparty #7118

Merged
merged 9 commits into from
Aug 26, 2024

Conversation

vishal-kanna
Copy link
Contributor

closes: #7115

@crodriguezvega crodriguezvega changed the title wip feat(eureka): add CLI to submit MsgProvideCounterparty Aug 12, 2024
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @vishal-kanna.

As an improvement for future PRs: when you open one, would you mind to open it with a descriptive title of what the PR tries to achieve? Thank you!

modules/core/02-client/client/cli/tx.go Outdated Show resolved Hide resolved
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am leaving my approval even though I contributed to the PR.

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@DimitrisJim DimitrisJim merged commit ed164c3 into cosmos:feat/ibc-eureka Aug 26, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants