feat(eureka): fix condition in commit packet, added test for zero timeout height #7109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange some error messages and add some more comments
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
crodriguezvega
commented
Aug 8, 2024
| @@ -67,7 +67,7 @@ func commitV2Packet(packet Packet) []byte { | |||
| timeoutBuf := sdk.Uint64ToBigEndian(packet.GetTimeoutTimestamp()) | |||
|
|
|||
| // only hash the timeout height if it is non-zero. This will allow us to remove it entirely in the future | |||
| if timeoutHeight.EQ(clienttypes.ZeroHeight()) { | |||
| if !timeoutHeight.EQ(clienttypes.ZeroHeight()) { | |||
There was a problem hiding this comment.
This is the most important fix in the PR.
There was a problem hiding this comment.
yea, seems like it was missed after the suggestion, great eye!
DimitrisJim
approved these changes
Aug 8, 2024
| @@ -67,7 +67,7 @@ func commitV2Packet(packet Packet) []byte { | |||
| timeoutBuf := sdk.Uint64ToBigEndian(packet.GetTimeoutTimestamp()) | |||
|
|
|||
| // only hash the timeout height if it is non-zero. This will allow us to remove it entirely in the future | |||
| if timeoutHeight.EQ(clienttypes.ZeroHeight()) { | |||
| if !timeoutHeight.EQ(clienttypes.ZeroHeight()) { | |||
There was a problem hiding this comment.
yea, seems like it was missed after the suggestion, great eye!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
commitV2Packetwhere timeout height should be hashed only if not empty.closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.