refactor: replace ack interface with result type for OnRecvPacket #7093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event func arg to use concrete type
damiannolan
commented
Aug 8, 2024
damiannolan
commented
Aug 8, 2024
There was a problem hiding this comment.
small bit of restructuring to the code here
damiannolan
commented
Aug 8, 2024
damiannolan
requested review from
colin-axner,
AdityaSripal,
srdtrk,
chatton,
DimitrisJim,
crodriguezvega,
gjermundgaraba and
bznein
as code owners
colin-axner
reviewed
Aug 8, 2024
colin-axner
reviewed
Aug 8, 2024
| suite.SetupTest() // reset | ||
| path = ibctesting.NewPath(suite.chainA, suite.chainB) | ||
|
|
||
| tc.malleate() | ||
|
|
||
| err := suite.chainB.App.GetIBCKeeper().ChannelKeeper.WriteAcknowledgement(suite.chainB.GetContext(), packet, ack) | ||
|
|
||
| if tc.expPass { | ||
| expPass := tc.expError == nil |
colin-axner
approved these changes
Aug 8, 2024
chatton
approved these changes
Aug 8, 2024
modules/apps/27-interchain-accounts/controller/ibc_middleware_test.go
Outdated
Show resolved
Hide resolved
|
|
||
| // String implements the fmt.Stringer interface. | ||
| func (r RecvPacketStatus) String() string { | ||
| return [...]string{"Success", "Failure", "Async"}[r] |
There was a problem hiding this comment.
do we need the [...] ? Can this just be a return []string{"Success", "Failure", "Async"}[r]
There was a problem hiding this comment.
I don't think its needed but I think its an optimisation(?).
Using the ... is essentially the same as having [3]string{"Success", "Failure", "Async"}[r] which makes an array with fixed size rather than a slice 🤷🏻♂️
damiannolan
commented
Aug 8, 2024
Comment on lines
+21
to
+27
| // Success instructs that the IBC application state should be persisted. | ||
| Success RecvPacketStatus = iota | ||
| // Failure instructs that the IBC application state should be discarded. | ||
| Failure | ||
| // Async instructs that the IBC application state should be persisted | ||
| // and acknowledgement data will be written later asynchronously. | ||
| Async |
There was a problem hiding this comment.
Note for follow up, we might want these as RecvStatusSuccess, RecvStatusFailure or something like that..
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
exported.Acknowledgementinterface and introduces a new concreteRecvPacketResulttype.closes: #7042
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.