feat(core/eureka): add timeout handler #7060
Conversation
AdityaSripal
changed the title
| suite.Require().NoError(err, "send packet failed") | ||
|
|
||
| // set packet receipt to mock a valid past receive | ||
| suite.chainB.App.GetIBCKeeper().ChannelKeeper.SetPacketReceipt(suite.chainB.GetContext(), packet.DestinationPort, packet.DestinationChannel, packet.Sequence) |
There was a problem hiding this comment.
Decided to just mock the receive here. I could do an actual receive but then would have to make sure the packet isn't timeout out for when the receive occurs but is timed out for the timeout and it ended up looking more confusing setup than just setting directly
AdityaSripal
requested review from
colin-axner,
damiannolan and
chatton
as code owners
| proofHeight exported.Height, | ||
| nextSequenceRecv uint64, | ||
| ) error { | ||
| // Lookup counterparty associated with our channel and ensure that destination channel |
There was a problem hiding this comment.
can we do protocol version check here too?
|
|
||
| // delete packet commitment to prevent replay | ||
| k.ChannelKeeper.DeletePacketCommitment(ctx, packet.SourcePort, packet.SourceChannel, packet.Sequence) | ||
|
|
There was a problem hiding this comment.
nit: can also do the log here (think we also missed it for Send)
| packet channeltypes.Packet, | ||
| proof []byte, | ||
| proofHeight exported.Height, | ||
| nextSequenceRecv uint64, |
There was a problem hiding this comment.
considering its relevant only for ordered which we do not have
| nextSequenceRecv uint64, | |
| _ uint64, |
| path := host.PacketReceiptKey(packet.DestinationPort, packet.DestinationChannel, packet.Sequence) | ||
| merklePath := types.BuildMerklePath(counterparty.MerklePathPrefix, path) | ||
|
|
||
| if err := k.ClientKeeper.VerifyNonMembership( |
There was a problem hiding this comment.
guess a client status check might also be nice here if working it in the tests isn't too much of a pain in the ass
| proof, | ||
| merklePath, | ||
| ); err != nil { | ||
| return err |
There was a problem hiding this comment.
we could wrap errors as 03-connection does, think I missed doing that too.
|
Description
closes: #6970
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.