Add Wrap/Unwrap Interfaces and implement OnChanOpenInit #7059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
commented
Aug 6, 2024
| @@ -22,13 +22,13 @@ func (im *LegacyIBCModule) GetCallbacks() []ClassicIBCModule { | |||
|
|
|||
| // NewLegacyIBCModule creates a new IBCModule given the keeper | |||
| func NewLegacyIBCModule(cbs ...ClassicIBCModule) ClassicIBCModule { | |||
| return LegacyIBCModule{ | |||
| return &LegacyIBCModule{ | |||
There was a problem hiding this comment.
small tweak since we need the reference type to implement the interface, not the value type.
chatton
requested review from
colin-axner,
AdityaSripal,
damiannolan and
srdtrk
as code owners
chatton
requested review from
crodriguezvega,
DimitrisJim,
gjermundgaraba and
bznein
as code owners
chatton
changed the title
colin-axner
reviewed
Aug 7, 2024
colin-axner
reviewed
Aug 7, 2024
| versionBytes, err := types.ModuleCdc.MarshalJSON(&versionMetadata) | ||
| if err != nil { | ||
| return "", err | ||
| if strings.TrimSpace(version) != "" && version != types.Version { |
|
…andle-backwards-compatibility' of github.com:cosmos/ibc-go into cian/issue#6954-add-version-wrap/unwrap-interfaces-to-handle-backwards-compatibility
colin-axner
approved these changes
Aug 7, 2024
colin-axner
deleted the
cian/issue#6954-add-version-wrap/unwrap-interfaces-to-handle-backwards-compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the optional VersionWrapper interface and implementation for ics29.
This PR ended up also implementing OnChanOpenInit in the LegacyIBCModule and updating all implementations to perform the new logic.
closes #7017
closes #6954
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.