feat(core/eureka): add recv handler #7041
Conversation
| if !ok { | ||
| return channeltypes.ErrChannelNotFound | ||
| } | ||
| if counterparty.ClientId != packet.SourceChannel { |
There was a problem hiding this comment.
removed the check for clientID == "", it is validated as non-empty in counterparty.Validate
|
|
||
| commitment := channeltypes.CommitPacket(packet) | ||
|
|
||
| if err := k.clientKeeper.VerifyMembership( |
There was a problem hiding this comment.
directly use client keeper method now instead of look-up of lcm and call (which also does status check)
| return err | ||
| } | ||
|
|
||
| // REPLAY PROTECTION: Packet receipts will indicate that a packet has already been received |
There was a problem hiding this comment.
add replay protection which was missing
| // is received for a certain sequence and for all duplicate receives. | ||
| func emitRecvPacketEvent(ctx sdk.Context, packet types.Packet, channel types.Channel) { | ||
| func EmitRecvPacketEvent(ctx sdk.Context, packet types.Packet, channel *types.Channel) { |
There was a problem hiding this comment.
think these event funcs should eventually be moved in an internal go package further up the source code tree and be re-used by both 04-channel and the eureka handling code
|
|
||
| func (k Keeper) RecvPacket( | ||
| ctx sdk.Context, | ||
| _ *capabilitytypes.Capability, |
There was a problem hiding this comment.
soon to be rm'ed in port router refactor
DimitrisJim
force-pushed
the
jim/recv-packet-eureka
branch
2 times, most recently
from
db933cb to
d8a7adc
Compare
DimitrisJim
force-pushed
the
jim/recv-packet-eureka
branch
from
d8a7adc to
7c982ec
Compare
DimitrisJim
requested review from
colin-axner,
damiannolan and
chatton
as code owners
|
Description
closes: #6968
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.