chore: split out packet handling rpcs #7007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
DimitrisJim
commented
Aug 1, 2024
| _ clienttypes.MsgServer = (*Keeper)(nil) | ||
| _ connectiontypes.MsgServer = (*Keeper)(nil) | ||
| _ channeltypes.MsgServer = (*Keeper)(nil) | ||
| _ channeltypes.PacketMsgServer = (*Keeper)(nil) |
There was a problem hiding this comment.
can also move to a packet_msg_server.go if people wanted. didn't since wanted to leave folder organization/shuffling for later
There was a problem hiding this comment.
I would like to see this split out eventually and moved to packet-server. But can be done in future PR
DimitrisJim
commented
Aug 1, 2024
DimitrisJim
commented
Aug 1, 2024
There was a problem hiding this comment.
could do with better names here
DimitrisJim
commented
Aug 1, 2024
|
|
||
| // BuildMerklePath takes the merkle path prefix and an ICS24 path | ||
| // and builds a new path by appending the ICS24 path to the last element of the merkle path prefix. | ||
| func BuildMerklePath(prefix *commitmenttypesv2.MerklePath, path []byte) commitmenttypesv2.MerklePath { |
There was a problem hiding this comment.
def will add tests, just want to get keeper in branch so we can start working on packet handlers.
AdityaSripal
approved these changes
Aug 1, 2024
| _ clienttypes.MsgServer = (*Keeper)(nil) | ||
| _ connectiontypes.MsgServer = (*Keeper)(nil) | ||
| _ channeltypes.MsgServer = (*Keeper)(nil) | ||
| _ channeltypes.PacketMsgServer = (*Keeper)(nil) |
There was a problem hiding this comment.
I would like to see this split out eventually and moved to packet-server. But can be done in future PR
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
split taken from ibc-lite branch, further splitting and shuffling of server impls planned as follow up.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.