chore: move status checks from connection verify_* functions to 02-client verify_* functions. #7006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient verify_* functions.
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
DimitrisJim
commented
Aug 1, 2024
| @@ -502,6 +502,134 @@ func (suite *KeeperTestSuite) TestGetTimestampAtHeight() { | |||
| } | |||
| } | |||
|
|
|||
| func (suite *KeeperTestSuite) TestVerifyMembership() { | |||
There was a problem hiding this comment.
these (both for membership and non membership) were missing apparently (probably because it simply routed before?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving status checks one layer down so as to not worry about them when directly calling
Verify(Non)Membershipin impl of eureka logic for packet handling.Can also target main if needed.
closes: #6980
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.