api!: delete v1 merkle path and register v2 merkle path against interface on cdc #6870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
colin-axner,
AdityaSripal and
chatton
as code owners
damiannolan
requested review from
gjermundgaraba,
crodriguezvega,
DimitrisJim and
bznein
DimitrisJim
approved these changes
Jul 18, 2024
crodriguezvega
approved these changes
Jul 18, 2024
gjermundgaraba
approved these changes
Jul 18, 2024
damiannolan
changed the title
damiannolan
requested review from
gjermundgaraba,
crodriguezvega and
DimitrisJim
damiannolan
commented
Jul 22, 2024
gjermundgaraba
approved these changes
Jul 22, 2024
bznein
approved these changes
Jul 25, 2024
crodriguezvega
approved these changes
Jul 25, 2024
colin-axner
approved these changes
Jul 29, 2024
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
…face on cdc (#6870) * fix: register codec v2.MerklePath against path interface * chore: delete merkle path v1 * docs: update migration doc for api removal * chore: update changelog * chore: make proto-swagger-gen * Update 13-v8-to-v9.md --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: colin axnér <[email protected]> (cherry picked from commit 84de38d) # Conflicts: # docs/docs/05-migrations/13-v8-to-v9.md
10 tasks
colin-axner
added a commit
that referenced
this pull request
Jul 30, 2024
…face on cdc (backport #6870) (#6983) * api!: delete v1 merkle path and register v2 merkle path against interface on cdc (#6870) * fix: register codec v2.MerklePath against path interface * chore: delete merkle path v1 * docs: update migration doc for api removal * chore: update changelog * chore: make proto-swagger-gen * Update 13-v8-to-v9.md --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: colin axnér <[email protected]> (cherry picked from commit 84de38d) # Conflicts: # docs/docs/05-migrations/13-v8-to-v9.md * chore: fix doc conflicts --------- Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: DimitrisJim <[email protected]> Co-authored-by: colin axnér <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v9 alpha audit.
This only really matters for encoding the type as protobuf Any which never really happens with merkle path types.
Good practise to register it anyways while the interface still exists.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.