Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ics4 callbacks fee middleware #580
ics4 callbacks fee middleware #580
Changes from 4 commits
4128f95
aa2e7a9
f7c8b07
c22a416
c77ae26
dc07eb5
7edb13b
86a5288
0029208
f7e7b71
59ca024
0dc1097
053f8f2
1e3b296
6ed040b
e8ff6d4
0625fa1
917b1ef
45cdb0c
b7e3b2d
75919dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a unit test for this? A followup pr is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create an issue. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't sure if/how we should handle this error. If this errs the code is broken elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could probably just panic. I'd say it's nicer than just ignoring the error, which could maybe be considered "bad code hygiene", and it seems to be done that way in other parts of the core codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just panicing makes sense here. This isn't run within the state machine anyway. So it actually is preferable to just panic if someone runs this command and finds this issue out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a panic. Not sure about the error message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdityaSripal I guess I need the
OnRecvPacket
functionality finished before I can write a test for this?#262
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea because
OnRecvPacket
should ONLY setForwardRelayerAddress
if the underlying application returns anil
acknowledgement. cc: @charleenfeiNo need to store it if you're going to send it out immediately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add a
Success
method here. Just returnfalse
ifForwardRelayerAddress
is empty, andtrue
otherwiseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @charleenfei has this on her branch. I'll copy it over
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the ModuleCdc in codec.go (rename to SubModuleCdc)