Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix expect pointer error when unmarshalling misbehaviour file #5020

Merged
merged 3 commits into from
Nov 6, 2023
Merged

fix expect pointer error when unmarshalling misbehaviour file #5020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb613b8
fix expect pointer error when unmarshalling misbehaviour file
mmsqe Nov 6, 2023
88ed2c0
Update CHANGELOG.md
mmsqe Nov 6, 2023
686bfaa
Merge branch 'main' into fix_misbehaviour
Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (testing) [\#4630](https://github.com/cosmos/ibc-go/pull/4630) Update `testconfig` to use revision formatted chain IDs.
* (core/04-channel) [\#4706](https://github.com/cosmos/ibc-go/pull/4706) Retrieve correct next send sequence for packets in unordered channels.
* (core/02-client) [\#4746](https://github.com/cosmos/ibc-go/pull/4746) Register implementations against `govtypes.Content` interface.
* (core/02-client) [\#5020](https://github.com/cosmos/ibc-go/pull/5020) Fix expect pointer error when unmarshalling misbehaviour file.

### Documentation

Expand Down
2 changes: 1 addition & 1 deletion modules/core/02-client/client/cli/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func newSubmitMisbehaviourCmd() *cobra.Command {
return fmt.Errorf("neither JSON input nor path to .json file for misbehaviour were provided: %w", err)
}

if err := cdc.UnmarshalInterfaceJSON(contents, misbehaviour); err != nil {
if err := cdc.UnmarshalInterfaceJSON(contents, &misbehaviour); err != nil {
return fmt.Errorf("error unmarshalling misbehaviour file: %w", err)
}
}
Expand Down
Loading