imp(statemachine)!: check length of unbounded string fields in messages #4992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gRegisterCounterpartyPayee` (#4870) * add check for length of counterparty payee in MsgRegisterCounterpartyPayee * change test value
* add length validation of receiver address in msg transfer * fix test. Next will add a test case that ensures that >2kb is rejected. * correct length of receiver address * lint * tidy * remove unused const / add test for recipient address length check * go mod tidy * Update msgs.go * rename variable * use testing value * fix package * lint --------- Co-authored-by: Du Nguyen <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
crodriguezvega
requested review from
AdityaSripal,
charleenfei,
colin-axner,
damiannolan,
chatton and
DimitrisJim
as code owners
3 tasks
crodriguezvega
changed the title
colin-axner
approved these changes
Oct 30, 2023
charleenfei
approved these changes
Oct 31, 2023
Co-authored-by: Charly <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4992 +/- ##
==========================================
+ Coverage 79.57% 79.59% +0.02%
==========================================
Files 189 189
Lines 13241 13256 +15
==========================================
+ Hits 10536 10551 +15
Misses 2284 2284
Partials 421 421
|
chatton
approved these changes
Oct 31, 2023
|
@crodriguezvega any plan for back porting this to v4.5.x? thanks |
This was referenced Nov 8, 2023
Closed
3 tasks
crodriguezvega
pushed a commit
that referenced
this pull request
Jun 18, 2024
10 tasks
crodriguezvega
pushed a commit
that referenced
this pull request
Jun 19, 2024
* chore: backport #4992 to release/v7.6.x * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #4859
Co-authored-by: Jacob Gadikian [email protected]
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.