Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: denom traces order #4709

Merged
merged 4 commits into from
Sep 19, 2023
Merged

fix: denom traces order #4709

merged 4 commits into from
Sep 19, 2023

Conversation

emidev98
Copy link
Contributor

Description

Changes the order of DenomTraces and DenomTrace rpc services to fix an issue when querying the endpoint using LCD. The query defaults to GET:/ibc/apps/transfer/v1/denom_traces/{hash=**} instead of /ibc/apps/transfer/v1/denom_traces when no parameter is available because of the RPC order definition.

An example of the issue:
image

A similar issue has been fixed using the same approach on terra-money/alliance#54

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

crodriguezvega
crodriguezvega approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @emidev98!

charleenfei
charleenfei approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @emidev98!

damiannolan
damiannolan approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

proto/ibc/applications/transfer/v1/query.proto
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order actually has implications on grpc web? interesting!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what we learned back in time, truly it was mind blowing for me too, but somehow makes sense that the order affects the result

@damiannolan damiannolan merged commit 1283efb into cosmos:main Sep 19, 2023
56 of 57 checks passed
@crodriguezvega crodriguezvega mentioned this pull request Oct 13, 2023
Closed
9 tasks
mergify bot pushed a commit that referenced this pull request Oct 17, 2023
@emidev98 @mergify
fix: order query service rpcs to fix availability of denom traces end…
82464a3 
…point when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go
#	modules/apps/transfer/types/query.pb.gw.go
@mergify mergify bot mentioned this pull request Oct 17, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 17, 2023
@emidev98 @mergify
fix: order query service rpcs to fix availability of denom traces end…
c872407 
…point when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go
#	modules/apps/transfer/types/query.pb.gw.go
mergify bot pushed a commit that referenced this pull request Oct 17, 2023
@emidev98 @mergify
fix: order query service rpcs to fix availability of denom traces end…
b51e3f1 
…point when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go
#	modules/apps/transfer/types/query.pb.gw.go
This was referenced Oct 17, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Oct 17, 2023
@emidev98 @mergify
fix: order query service rpcs to fix availability of denom traces end…
903bd7d 
…point when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go
#	modules/apps/transfer/types/query.pb.gw.go
@mergify mergify bot mentioned this pull request Oct 17, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 17, 2023
@emidev98 @mergify
fix: order query service rpcs to fix availability of denom traces end…
a6a01f9 
…point when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go
#	modules/apps/transfer/types/query.pb.gw.go
mergify bot pushed a commit that referenced this pull request Oct 17, 2023
@emidev98 @mergify
fix: order query service rpcs to fix availability of denom traces end…
9e3fe2d 
…point when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go
@mergify mergify bot mentioned this pull request Oct 17, 2023
Merged
@mergify mergify bot mentioned this pull request Oct 17, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 17, 2023
@emidev98 @mergify
fix: order query service rpcs to fix availability of denom traces end…
6b27233 
…point when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go
@mergify mergify bot mentioned this pull request Oct 17, 2023
Merged
DimitrisJim pushed a commit that referenced this pull request Oct 19, 2023
@mergify @emidev98
fix: denom traces order (backport #4709) (#4884)
5626283 
* fix: order query service rpcs to fix availability of denom traces endpoint when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go
#	modules/apps/transfer/types/query.pb.gw.go

* add changelog

* fix conflicts

---------

Co-authored-by: Emi <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
DimitrisJim pushed a commit that referenced this pull request Oct 19, 2023
@mergify @emidev98
fix: denom traces order (backport #4709) (#4885)
627fbd4 
* fix: order query service rpcs to fix availability of denom traces endpoint when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go
#	modules/apps/transfer/types/query.pb.gw.go

* add changelog

* fix conflicts

---------

Co-authored-by: Emi <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
DimitrisJim pushed a commit that referenced this pull request Oct 19, 2023
@mergify @emidev98
fix: denom traces order (backport #4709) (#4886)
12522f3 
* fix: order query service rpcs to fix availability of denom traces endpoint when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go

* add changelog

* fix conflicts

* fix some markdown links

* fix more markdown links

* fix even more links

---------

Co-authored-by: Emi <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
DimitrisJim pushed a commit that referenced this pull request Oct 19, 2023
@mergify @emidev98
fix: denom traces order (backport #4709) (#4887)
ff4df17 
* fix: order query service rpcs to fix availability of denom traces endpoint when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go

* add changelog

* fix conflicts

* fix markdown links

---------

Co-authored-by: Emi <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
crodriguezvega pushed a commit that referenced this pull request Oct 19, 2023
@mergify @emidev98
fix: denom traces order (backport #4709) (#4881)
cb672be 
* fix: order query service rpcs to fix availability of denom traces endpoint when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go
#	modules/apps/transfer/types/query.pb.gw.go

* fix conflicts

* add changelog

---------

Co-authored-by: Emi <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
crodriguezvega pushed a commit that referenced this pull request Oct 19, 2023
@mergify @emidev98
fix: denom traces order (backport #4709) (#4882)
27adefe 
* fix: order query service rpcs to fix availability of denom traces endpoint when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go
#	modules/apps/transfer/types/query.pb.gw.go

* add changelog

* fix conflicts

---------

Co-authored-by: Emi <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
crodriguezvega pushed a commit that referenced this pull request Oct 19, 2023
@mergify @emidev98
fix: denom traces order (backport #4709) (#4883)
945d5b1 
* fix: order query service rpcs to fix availability of denom traces endpoint when no args are provided (#4709)

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
(cherry picked from commit 1283efb)

# Conflicts:
#	modules/apps/transfer/types/query.pb.go
#	modules/apps/transfer/types/query.pb.gw.go

* add changelog

* fix conflicts

---------

Co-authored-by: Emi <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleenfei charleenfei charleenfei approved these changes

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@damiannolan damiannolan damiannolan approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emidev98 @damiannolan @crodriguezvega @charleenfei @DimitrisJim