-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query): get next send sequence for transfer packets #4706
Conversation
what else should I do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dzmitry-lahoda. It would be good to fix this test. You can do something like it is done in this other test for ordered channels, where the next sequence send is set and then the test check that the query returns the expected value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @dzmitry-lahoda!
Co-authored-by: Carlos Rodriguez <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4706 +/- ##
==========================================
+ Coverage 79.65% 79.69% +0.03%
==========================================
Files 187 187
Lines 13195 13186 -9
==========================================
- Hits 10511 10508 -3
+ Misses 2253 2248 -5
+ Partials 431 430 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dzmitry-lahoda! I think we can remove the check on the channel lookup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dzmitry-lahoda! LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dzmitry-lahoda for the issue and the fix! :)
It looks like the pr will need to be brought up to date with main, if you allow maintainers write access (usually a button you can click on the side), we can manage this for you |
@colin-axner @damiannolan will this be included in v8 of ibc go? thanks https://github.com/cosmos/ibc-go/blob/main/docs/docs/01-ibc/09-roadmap.md |
Hey @josietyleung, yes it will be included in the v8 release 👍 |
Description
closes: #4698
Commit Message / Changelog Entry
feat(packet): get next send sequence for transfer packets
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.