-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove ica storekey #4677
chore: remove ica storekey #4677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @faddat. Would it be possible to take all the module bumps out of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @faddat, lgtm! 🚀
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4677 +/- ##
=======================================
Coverage 79.65% 79.66%
=======================================
Files 187 187
Lines 13195 13196 +1
=======================================
+ Hits 10511 10512 +1
Misses 2253 2253
Partials 431 431
|
Description
Remove ICA StoreKey
closes: #4644
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.