-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add argument to generate-packet-data
cli to use selected encoding format
#4537
cli: add argument to generate-packet-data
cli to use selected encoding format
#4537
Conversation
…tacmd-cli-to-use-proper-encoding-format
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4537 +/- ##
==========================================
- Coverage 79.26% 79.20% -0.06%
==========================================
Files 188 188
Lines 13054 13063 +9
==========================================
Hits 10347 10347
- Misses 2273 2282 +9
Partials 434 434
|
Should we backport this to |
…tacmd-cli-to-use-proper-encoding-format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment about possibly backporting this
Yes, sounds good. We can do that. |
…tacmd-cli-to-use-proper-encoding-format
Co-authored-by: Damian Nolan <[email protected]>
…tacmd-cli-to-use-proper-encoding-format
…ing format (#4537) * add encoding parameter to cli * updated docs * testing encoding parameter of cli * linter fixes * review feedback * Update client.md * typos * Update modules/apps/27-interchain-accounts/host/client/cli/tx.go Co-authored-by: Damian Nolan <[email protected]> * address review feedback --------- Co-authored-by: srdtrk <[email protected]> Co-authored-by: Damian Nolan <[email protected]> (cherry picked from commit 1e3eee6) # Conflicts: # modules/apps/27-interchain-accounts/host/client/cli/tx.go # modules/apps/27-interchain-accounts/host/client/cli/tx_test.go
…ing format (backport #4537) (#4569) * imp: add argument to `generate-packet-data` cli to use selected encoding format (#4537) * add encoding parameter to cli * updated docs * testing encoding parameter of cli * linter fixes * review feedback * Update client.md * typos * Update modules/apps/27-interchain-accounts/host/client/cli/tx.go Co-authored-by: Damian Nolan <[email protected]> * address review feedback --------- Co-authored-by: srdtrk <[email protected]> Co-authored-by: Damian Nolan <[email protected]> (cherry picked from commit 1e3eee6) # Conflicts: # modules/apps/27-interchain-accounts/host/client/cli/tx.go # modules/apps/27-interchain-accounts/host/client/cli/tx_test.go * fix: fixed backport conflicts * add changelog --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: srdtrk <[email protected]>
Description
closes: #3974
Commit Message / Changelog Entry
imp: add argument to `generate-packet-data` cli to use selected encoding format
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.