imp(apps): added 'WithICS4Wrapper' function to keepers #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdtrk
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4187 +/- ##
==========================================
+ Coverage 79.45% 79.46% +0.01%
==========================================
Files 188 188
Lines 12990 12969 -21
==========================================
- Hits 10321 10306 -15
+ Misses 2240 2234 -6
Partials 429 429
|
colin-axner
approved these changes
Jul 27, 2023
|
In that case, should I add it to icahost too @colin-axner? |
Good question. It's not necessary, but it might be nice to do for consistency sake. It's useful to define the ics4wrapper after generating all the ibc modules. So I would be in favour of doing so, but I can go either way. Happy to wait to hear if others have an opinion next week |
srdtrk
changed the title
crodriguezvega
approved these changes
Jul 28, 2023
Comment on lines
+69
to
+71
| // WithICS4Wrapper sets the ICS4Wrapper. This function may be used after | ||
| // the keepers creation to set the middleware which is above this module | ||
| // in the IBC application stack. |
There was a problem hiding this comment.
Maybe I would try to elaborate a bit more in what circumstances you would use this function.
There was a problem hiding this comment.
I can't think of other circumstances 😅
| _, isFeeKeeper := ics4Wrapper.(keeper.Keeper) | ||
| suite.Require().False(isFeeKeeper) | ||
|
|
||
| // set the ics4 wrapper to itself (don't do this in production) |
damiannolan
approved these changes
Jul 31, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
* imp(ica, transfer): added WithICS4Wrapper api function * docs(ica, transfer): updated 'WithICS4Wrapper's godocs * docs(adr8): updated godocs for withics4wrapper * imp(ica/host): removed withics4wrapper from icahost * style(ica, tranfer): ran golanci-lint * imp(ica/controller_test): added WithICS4Wrapper test * imp(transfer_test): added WithICS4Wrapper test * style(transfer_test, ica/controller_test): added spacing to TestWithICS4Wrapper * feat(ica/host): implemented 'WithICS4Wrapper' * feat(fee): implemented 'WithICS4Wrapper' (cherry picked from commit 561eb36) # Conflicts: # modules/apps/27-interchain-accounts/controller/keeper/keeper_test.go # modules/apps/27-interchain-accounts/host/keeper/keeper_test.go # modules/apps/transfer/keeper/keeper.go # modules/apps/transfer/keeper/keeper_test.go
srdtrk
added a commit
that referenced
this pull request
Aug 1, 2023
… (#4210) * imp(apps): added 'WithICS4Wrapper' function to keepers (#4187) * imp(ica, transfer): added WithICS4Wrapper api function * docs(ica, transfer): updated 'WithICS4Wrapper's godocs * docs(adr8): updated godocs for withics4wrapper * imp(ica/host): removed withics4wrapper from icahost * style(ica, tranfer): ran golanci-lint * imp(ica/controller_test): added WithICS4Wrapper test * imp(transfer_test): added WithICS4Wrapper test * style(transfer_test, ica/controller_test): added spacing to TestWithICS4Wrapper * feat(ica/host): implemented 'WithICS4Wrapper' * feat(fee): implemented 'WithICS4Wrapper' (cherry picked from commit 561eb36) # Conflicts: # modules/apps/27-interchain-accounts/controller/keeper/keeper_test.go # modules/apps/27-interchain-accounts/host/keeper/keeper_test.go # modules/apps/transfer/keeper/keeper.go # modules/apps/transfer/keeper/keeper_test.go * fix: fixed backport conflicts --------- Co-authored-by: srdtrk <[email protected]> Co-authored-by: srdtrk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is first one of the upcoming PRs requested by @colin-axner to reduce the diff when reviewing #3939
This function allows to set the middleware after the keeper's creation.
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.Updated relevant documentation (docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.