refactor: change sdk.Events usage to []abci.Event #3980
Conversation
| @@ -163,7 +163,7 @@ func (suite *KeeperTestSuite) TestDistributeFeeEvent() { | |||
| sdk.NewAttribute(types.AttributeKeyReceiver, suite.chainA.SenderAccount.GetAddress().String()), | |||
| sdk.NewAttribute(types.AttributeKeyFee, defaultTimeoutFee.String()), | |||
| ), | |||
| } | |||
| }.ToABCIEvents() | |||
There was a problem hiding this comment.
for convenience I left as is and called ToABCIEvents() since sdk.Events is just a wrapper around []abci.Event
| @@ -6,7 +6,7 @@ import ( | |||
|
|
|||
| "github.com/stretchr/testify/suite" | |||
|
|
|||
| sdk "github.com/cosmos/cosmos-sdk/types" | |||
| abci "github.com/cometbft/cometbft/abci/types" | |||
There was a problem hiding this comment.
seems like we have slight inconsistency between abci alias and abcitypes alias. I think I prefer abci just because there is no go file at that level https://github.com/cometbft/cometbft/tree/main/abci, but I don't have a strong preference. We can make consistent in a followup
colin-axner
requested review from
AdityaSripal,
charleenfei,
damiannolan,
crodriguezvega,
chatton and
DimitrisJim
as code owners
| @@ -6,7 +6,7 @@ import ( | |||
|
|
|||
| "github.com/stretchr/testify/suite" | |||
|
|
|||
| sdk "github.com/cosmos/cosmos-sdk/types" | |||
| abci "github.com/cometbft/cometbft/abci/types" | |||
oh yea! My bad. Fixed :) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3980 +/- ##
=======================================
Coverage 78.84% 78.84%
=======================================
Files 187 187
Lines 12950 12950
=======================================
Hits 10211 10211
Misses 2311 2311
Partials 428 428
|
|
@charleenfei I agree. Definitely think this is a helpful change. |
Description
Note: When changing from
*sdk.Resultto*abci.ExecTxResult,GetEvents()would have begun returning[]abci.Event, but I decided to pull out these changes anyways to reduce the burden of "why is this changing" on reviewers when reviewing the update to SDK v0.50Let me know if you think this deserves a changelog even if no code changes would need to be made by downstream users since they would update to this change at the same time as the SDK bump
closes: #3979
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.