fix(statemachine)!: re-implement legacy msg interface #3907
Conversation
crodriguezvega
requested review from
AdityaSripal,
charleenfei,
colin-axner and
damiannolan
as code owners
| func (msg MsgPayPacketFee) Route() string { | ||
| return RouterKey | ||
| } | ||
|
|
||
| // GetSignBytes implements sdk.Msg. | ||
| // GetSignBytes implements legacytx.LegacyMsg |
There was a problem hiding this comment.
This docstring can remain sdk.Msg I believe?
There was a problem hiding this comment.
I changed it because it looks like GetSignBytes is not part of the sdk.Msg interface, but of the LegacyMsg interface instead...
There was a problem hiding this comment.
either works for me, it will be removed post eden I guess
Is this going to require a change to the ledger software, so that it can sign protos? |
I'm unsure on this, it may be supported by |
damiannolan
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3907 +/- ##
==========================================
- Coverage 78.88% 78.84% -0.04%
==========================================
Files 187 187
Lines 12944 12950 +6
==========================================
Hits 10211 10211
- Misses 2305 2311 +6
Partials 428 428
|
|
ledger support of sign mode textual is released and audited. We are just waiting for it to be included into ledger live |
(cherry picked from commit f2b2249) # Conflicts: # modules/apps/29-fee/types/msgs.go # modules/apps/transfer/types/msgs.go
#3938) * fix(statemachine)!: re-implement legacy msg interface (#3907) (cherry picked from commit f2b2249) # Conflicts: # modules/apps/29-fee/types/msgs.go # modules/apps/transfer/types/msgs.go * resolving backport conflicts --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Damian Nolan <[email protected]>
Description
Removing the
Type()function implementation in this PR broke transaction signing with ledger. This PR adds it back together with some extra type checking to make sure types implement the necessary interfaces. I will open a follow up issue to remove the implementation ofLegacyMsginterface when we upgrade to SDK v0.50.x.closes: #XXXX
Commit Message / Changelog Entry
fix(statemachine)!: re-implement legacy msg interfacesee the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.