Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

barberry (bump SDK v0.47.3) #3810

Merged
merged 7 commits into from
Jun 12, 2023
Merged

barberry (bump SDK v0.47.3) #3810

merged 7 commits into from
Jun 12, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jun 10, 2023

This PR patches ibc-go for barberry, which also means making a few other version
bumps, too.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @faddat! I only left one comment: I think we should bump go version in a separate PR.

go.mod Outdated Show resolved Hide resolved
@faddat
Copy link
Contributor Author

faddat commented Jun 12, 2023

Sure thing, sorry about the duplication here. I'll take care of that right now also

@faddat
Copy link
Contributor Author

faddat commented Jun 12, 2023

@crodriguezvega hey another thing I should make you aware of with this one -- it moves go.work.example to go.work, I am going to make that a separate PR though.

I think we should do that because it is the way that Osmosis is handling this, and it is really nice. Basically, we can:

keep go.work.sum in .gitignotre
commit go.work

this way when a dev sits down to work, they can

go work sync

and everything goes great. I usually label the resulting commit "sync"

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙏 @faddat. We will back port this to v7.2, once we open that release branch.

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @faddat !

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @faddat

@colin-axner colin-axner merged commit cf593b7 into cosmos:main Jun 12, 2023
mergify bot pushed a commit that referenced this pull request Jun 22, 2023
* barberry

* sync

* add replaces for goleveldb

* move back to go 1.19

* move go.work back to go.work.example

(cherry picked from commit cf593b7)

# Conflicts:
#	e2e/go.mod
#	e2e/go.sum
#	go.mod
#	go.sum
#	modules/capability/go.mod
#	modules/capability/go.sum
crodriguezvega pushed a commit that referenced this pull request Jun 22, 2023
* barberry (bump SDK v0.47.3) (#3810)

* barberry

* sync

* add replaces for goleveldb

* move back to go 1.19

* move go.work back to go.work.example

(cherry picked from commit cf593b7)

# Conflicts:
#	e2e/go.mod
#	e2e/go.sum
#	go.mod
#	go.sum
#	modules/capability/go.mod
#	modules/capability/go.sum

* fix conflicts/add changelog

---------

Co-authored-by: Jacob Gadikian <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
@faddat faddat mentioned this pull request Jun 23, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants