-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
barberry (bump SDK v0.47.3) #3810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @faddat! I only left one comment: I think we should bump go version in a separate PR.
Sure thing, sorry about the duplication here. I'll take care of that right now also |
@crodriguezvega hey another thing I should make you aware of with this one -- it moves go.work.example to go.work, I am going to make that a separate PR though. I think we should do that because it is the way that Osmosis is handling this, and it is really nice. Basically, we can: keep go.work.sum in .gitignotre this way when a dev sits down to work, they can go work sync and everything goes great. I usually label the resulting commit "sync" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🙏 @faddat. We will back port this to v7.2, once we open that release branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you @faddat !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @faddat
* barberry * sync * add replaces for goleveldb * move back to go 1.19 * move go.work back to go.work.example (cherry picked from commit cf593b7) # Conflicts: # e2e/go.mod # e2e/go.sum # go.mod # go.sum # modules/capability/go.mod # modules/capability/go.sum
* barberry (bump SDK v0.47.3) (#3810) * barberry * sync * add replaces for goleveldb * move back to go 1.19 * move go.work back to go.work.example (cherry picked from commit cf593b7) # Conflicts: # e2e/go.mod # e2e/go.sum # go.mod # go.sum # modules/capability/go.mod # modules/capability/go.sum * fix conflicts/add changelog --------- Co-authored-by: Jacob Gadikian <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
This PR patches ibc-go for barberry, which also means making a few other version
bumps, too.