Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : added annotation to Msg service #3630

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

vishal-kanna
Copy link
Contributor

@vishal-kanna vishal-kanna commented May 23, 2023

Description

closes: #3625

Commit Message / Changelog Entry

feat : add annotation to denote service messages

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@DimitrisJim
Copy link
Contributor

DimitrisJim commented May 24, 2023

hey here too 👋. The same issue as the one I highlighted in my comment #3627 (comment) on your other PR exists here too so, if we're to wait for the other issue, lets wait here too yeah?

@DimitrisJim
Copy link
Contributor

Hey @vishal-kanna, seems to me that this PR can move forward. As far as I can tell, the pull request for migrating params for ica/host is the only one that added a new tx.proto file. As such, annotating the services should be able to move forward just fine since all other pull requests simply add an rpc to it.

Let me know if you need anything else!

# Conflicts:
#	modules/apps/transfer/types/tx.pb.go
#	modules/core/02-client/types/tx.pb.go
#	proto/ibc/applications/transfer/v1/tx.proto
#	proto/ibc/core/client/v1/tx.proto
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vishal-kanna!

# Conflicts:
#	modules/apps/27-interchain-accounts/controller/types/tx.pb.go
#	modules/apps/27-interchain-accounts/host/types/tx.pb.go
#	modules/apps/29-fee/types/tx.pb.go
#	modules/apps/transfer/types/tx.pb.go
#	modules/core/02-client/types/tx.pb.go
#	modules/core/03-connection/types/tx.pb.go
#	modules/core/04-channel/types/tx.pb.go
#	proto/ibc/applications/fee/v1/tx.proto
#	proto/ibc/applications/interchain_accounts/controller/v1/tx.proto
@crodriguezvega crodriguezvega merged commit d751bc9 into cosmos:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use option extension to signal services in protobuf files
4 participants