chore: transfer authz nits #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d potential pitfalls
damiannolan
commented
May 16, 2023
Comment on lines
-96
to
+98
| updatedTransferAuthz, ok := res.Updated.(*types.TransferAuthorization) | ||
| suite.Require().True(ok) | ||
|
|
||
| remainder := updatedTransferAuthz.Allocations[0].SpendLimit.AmountOf(sdk.DefaultBondDenom) | ||
| suite.Require().True(types.UnboundedSpendLimit().Equal(remainder)) | ||
| suite.Require().True(res.Accept) | ||
| suite.Require().False(res.Delete) | ||
| suite.Require().Nil(res.Updated) |
There was a problem hiding this comment.
I was going to do a stateful lookup using the authz keeper to maintain the same checks but we don't actually register the transfer authorization for these tests, its bypassed. I think this is fine tho!
colin-axner
approved these changes
May 16, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3586 +/- ##
=======================================
Coverage 78.79% 78.79%
=======================================
Files 182 182
Lines 12688 12688
=======================================
Hits 9998 9998
Misses 2258 2258
Partials 432 432
|
9 tasks
This was referenced May 16, 2023
colin-axner
pushed a commit
that referenced
this pull request
May 16, 2023
* chore: optimise transfer authz to consume less gas for unbounded spend limits (#3586) (cherry picked from commit f6e8f03) # Conflicts: # modules/apps/transfer/types/transfer_authorization.go * resolve conflicts --------- Co-authored-by: Damian Nolan <[email protected]>
colin-axner
pushed a commit
that referenced
this pull request
May 16, 2023
* chore: optimise transfer authz to consume less gas for unbounded spend limits (#3586) (cherry picked from commit f6e8f03) # Conflicts: # modules/apps/transfer/types/transfer_authorization.go * resolve conflicts --------- Co-authored-by: Damian Nolan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3454 (comment)
nilto consume less gas and avoid potential pitfallscloses: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.