-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing query for next sequence send #3417
Add missing query for next sequence send #3417
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3417 +/- ##
==========================================
- Coverage 78.59% 78.54% -0.06%
==========================================
Files 181 181
Lines 12546 12581 +35
==========================================
+ Hits 9861 9882 +21
- Misses 2252 2265 +13
- Partials 433 434 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @expertdicer. There are a few places where receive
is used instead of send
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @expertdicer. I just realised there were a couple of other naming typos, but apart from that it looks good to me. I think we can ignore the lint warning receiver name k should be consistent with previous receiver name q for Keeper
, since all the other receiver names will be renamed in a different PR.
I fixed the typos but I think there are typos in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the PR @expertdicer, very clean!
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
No, no need to fix those in this PR. :) We can do that in a follow-up. |
@expertdicer Just one more thing :) Could you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
closes: #3383
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.