fix: allow retries for messages signed by relayer. #3402
Conversation
DimitrisJim
requested review from
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan and
chatton
as code owners
There was a problem hiding this comment.
Thank you, @DimitrisJim! It's looking good; I just left a bunch for nits.
e2e/testsuite/testsuite.go
Outdated
| // retryNtimes retries the provided function up to the provided number of attempts. | ||
| func (s *E2ETestSuite) retryNtimes(f func() (sdk.TxResponse, error), attempts int) (sdk.TxResponse, error) { | ||
| // Ignore account sequence mismatch errors. | ||
| allowedMessages := []string{"account sequence mismatch"} |
There was a problem hiding this comment.
Since this is a configuration parameter, maybe we can move it to the top together with the const? We can make it an unexpected var.
e2e/testsuite/testsuite.go
Outdated
| @@ -60,6 +60,7 @@ type E2ETestSuite struct { | |||
|
|
|||
| grpcClients map[string]GRPCClients | |||
| paths map[string]path | |||
| relayers map[ibc.Wallet]bool | |||
There was a problem hiding this comment.
while we do currently just run a single test in each run, we should try and make sure that if we change that we need to make as few changes as possible. With relayers being at the top level, this means that these relayer wallets would be shared across all tests. What might make sense to do is to create a mapping of testName -> relayer pair. Similar to how we do here.
This could even be a map[string]map[ibc.Wallet]bool which isn't super pretty, but maybe we could work with an alias of some sort here.
There was a problem hiding this comment.
I did go with an alias here and basically just added a couple of functions on it. Lmk what you think.
There was a problem hiding this comment.
Excellent work @DimitrisJim! Left a few suggestions, but overall looks great to me! Have we seen this solution work in the logs?
|
@colin-axner re: have we seen it work in the logs. Not so far as far as I can tell, I've searched the logs for the added log |
Co-authored-by: Cian Hatton <[email protected]>
…relayer-wallet-to-sign-ibc-tx-msgs
…relayer-wallet-to-sign-ibc-tx-msgs
DimitrisJim
deleted the
jim/3264-avoid-sequence-mismatch-when-using-relayer-wallet-to-sign-ibc-tx-msgs
branch
Description
closes: #3264
Commit Message / Changelog Entry
fix: allow retries for messages signed by relayer.see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.