chore: remove legacy interface function, RandomizedParams, which is no longer used #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove RandomizedParams which has been removed from the AppModuleSimulation interface. Remove associated ParamChanges helper functions
colin-axner
requested review from
AdityaSripal,
charleenfei and
damiannolan
as code owners
colin-axner
commented
Feb 15, 2023
colin-axner
added a commit
that referenced
this pull request
Feb 15, 2023
julienrbrt
reviewed
Feb 15, 2023
| @@ -175,11 +174,6 @@ func (AppModule) ProposalContents(_ module.SimulationState) []simtypes.WeightedP | |||
| return nil | |||
There was a problem hiding this comment.
You can delete this of all modules if you don't use it.
And as mentioned here, if you keep it, it should be still returning WeightedProposalContent.
There was a problem hiding this comment.
We will delete it as it is unused 👍 Thanks for reviewing!
damiannolan
added a commit
that referenced
this pull request
Feb 15, 2023
* adding migration doc info for sdk v0.47 * code alignment * title formatting * chore: preemptively apply changes from #3149 * chore: apply changes from #3150 * chore: formatting * chore: combine proposal contents removal into existing section --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Colin Axnér <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
* adding migration doc info for sdk v0.47 * code alignment * title formatting * chore: preemptively apply changes from #3149 * chore: apply changes from #3150 * chore: formatting * chore: combine proposal contents removal into existing section --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Colin Axnér <[email protected]> (cherry picked from commit f034e6b) # Conflicts: # docs/migrations/v6-to-v7.md
chatton
approved these changes
Feb 15, 2023
stackman27
pushed a commit
to stackman27/ibc-go
that referenced
this pull request
Mar 13, 2023
* adding migration doc info for sdk v0.47 * code alignment * title formatting * chore: preemptively apply changes from cosmos#3149 * chore: apply changes from cosmos#3150 * chore: formatting * chore: combine proposal contents removal into existing section --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Colin Axnér <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While reviewing changes, I noticed this function had been removed from the SDK AppModuleSimulation function
closes: #3148
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.