-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: e2e localhost test create new channel for existing ica account #3146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, fantastic work! The code is so clean and beautiful! Was really easy to follow the logic of what was happening
events := testsuite.ABCIToSDKEvents(txResp.Events) | ||
packet, err = ibctesting.ParsePacketFromEvents(events) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty nice how this came to be so valuable here! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM left one suggestions for a followup improvement but this looks great! Nice work ❤️
// relayer and channel output is discarded, only a single chain is required | ||
_, _ = s.SetupChainsRelayerAndChannel(ctx) | ||
chainA, _ := s.GetChains() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should create an issue to add a second setup function which only spins up a single chain, could be useful for localhost/non-ibc e2e tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, definitely agree!
Description
Steps are as follows:
MsgRegisterInterchainAccount
(channel open init).ref: #3033
Commit Message / Changelog Entry
NA
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.