imp: add page result to ics29-fee queries #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3054 +/- ##
=======================================
Coverage 78.53% 78.54%
=======================================
Files 179 179
Lines 12436 12440 +4
=======================================
+ Hits 9767 9771 +4
Misses 2243 2243
Partials 426 426
|
aleem1314
requested review from
AdityaSripal,
charleenfei,
colin-axner and
damiannolan
as code owners
|
@aleem1314 Thanks a lot of working on this improvement! Would you mind to update your branch with the latest changes from main and regenerate the proto files? There has been some changes on one of the |
damiannolan
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Thanks @aleem1314 looks good to me! Maybe we can treat this as an improvement rather than a feature wrt changelog entry :)
aleem1314
changed the title
crodriguezvega
approved these changes
Feb 7, 2023
stackman27
pushed a commit
to stackman27/ibc-go
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add page result to
IncentivizedPackets,IncentivizedPacketsForChannelandFeeEnabledChannelsics29-fee queries.closes: #2894
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.