Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change check to disallow optimistic sends #3009

Merged
merged 9 commits into from
Jan 18, 2023
Merged

fix: change check to disallow optimistic sends #3009

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ab7b9de
change check to disallow optimistic sends
charleenfei Jan 13, 2023
d11827e
Merge branch 'main' into charly/optimistic_sends
charleenfei Jan 17, 2023
c094819
update test
charleenfei Jan 17, 2023
cd5e25e
nolint
charleenfei Jan 17, 2023
c47ec02
rm commented out code block
charleenfei Jan 18, 2023
ece6007
fix endpoints
charleenfei Jan 18, 2023
8d90eb7
update endpoint
charleenfei Jan 18, 2023
defe2af
update pr comment
charleenfei Jan 18, 2023
491f8b9
Merge branch 'main' into charly/optimistic_sends
charleenfei Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/core/04-channel/keeper/packet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func (k Keeper) SendPacket(
return 0, sdkerrors.Wrap(types.ErrChannelNotFound, sourceChannel)
}

if channel.State == types.CLOSED {
if channel.State != types.OPEN {
crodriguezvega marked this conversation as resolved.
Show resolved Hide resolved
return 0, sdkerrors.Wrapf(
types.ErrInvalidChannelState,
"channel is CLOSED (got %s)", channel.State.String(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe change the error text to something like channel is not OPEN...?

Expand Down