-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding distribute fee events to ics29 #2975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clean LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we extend the existing tests to use the brand new AssertEvents
function to check that the events emitted are what we expect?
Most of the existing tests call into the keeper functions directly. To get at the events we'll need to route a new |
@@ -81,3 +86,80 @@ func (suite *KeeperTestSuite) TestIncentivizePacketEvent() { | |||
} | |||
} | |||
} | |||
|
|||
func (suite *KeeperTestSuite) TestDistributeFeeEvent() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Thanks, @damiannolan!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not the prettiest test, but it should do the job. Sadly, we can't really emit whether its a recv, ack or timeout fee within the events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one, lgtm!
…ts` (#2995) * refactor: add support for asserting multiple events of the same type * change condition checking to make test pass * review comment * rename variable
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2975 +/- ##
==========================================
+ Coverage 78.41% 78.45% +0.04%
==========================================
Files 178 178
Lines 12327 12343 +16
==========================================
+ Hits 9666 9684 +18
+ Misses 2236 2234 -2
Partials 425 425
|
Description
closes: #2847
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.