Add ICS27 e2e test with governance #2808
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,149 @@ | ||||||
| package interchain_accounts | ||||||
|
|
||||||
| import ( | ||||||
| "context" | ||||||
| "testing" | ||||||
| "time" | ||||||
|
|
||||||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||||||
| banktypes "github.com/cosmos/cosmos-sdk/x/bank/types" | ||||||
| govtypes "github.com/cosmos/cosmos-sdk/x/gov/types" | ||||||
| govtypesv1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1" | ||||||
| "github.com/gogo/protobuf/proto" | ||||||
|
There was a problem hiding this comment. nit on separation of imports There was a problem hiding this comment. Based on the three categories of imports stdlib / external libs / our libs, I would say that these imports are correctly grouped. WDYT? |
||||||
| "github.com/strangelove-ventures/ibctest/v6" | ||||||
| "github.com/strangelove-ventures/ibctest/v6/chain/cosmos" | ||||||
| "github.com/strangelove-ventures/ibctest/v6/ibc" | ||||||
| "github.com/strangelove-ventures/ibctest/v6/test" | ||||||
| "github.com/stretchr/testify/suite" | ||||||
|
|
||||||
| "github.com/cosmos/ibc-go/e2e/testsuite" | ||||||
| "github.com/cosmos/ibc-go/e2e/testvalues" | ||||||
| controllertypes "github.com/cosmos/ibc-go/v6/modules/apps/27-interchain-accounts/controller/types" | ||||||
| icatypes "github.com/cosmos/ibc-go/v6/modules/apps/27-interchain-accounts/types" | ||||||
| ibctesting "github.com/cosmos/ibc-go/v6/testing" | ||||||
| ) | ||||||
|
|
||||||
| func TestInterchainAccountsGovTestSuite(t *testing.T) { | ||||||
| suite.Run(t, new(InterchainAccountsGovTestSuite)) | ||||||
| } | ||||||
|
|
||||||
| type InterchainAccountsGovTestSuite struct { | ||||||
| testsuite.E2ETestSuite | ||||||
| } | ||||||
|
|
||||||
| func (s *InterchainAccountsGovTestSuite) TestInterchainAccountsGovIntegration() { | ||||||
| t := s.T() | ||||||
| ctx := context.TODO() | ||||||
|
|
||||||
| // setup relayers and connection-0 between two chains | ||||||
| // channel-0 is a transfer channel but it will not be used in this test case | ||||||
| relayer, _ := s.SetupChainsRelayerAndChannel(ctx) | ||||||
| chainA, chainB := s.GetChains() | ||||||
| controllerAccount := s.CreateUserOnChainA(ctx, testvalues.StartingTokenAmount) | ||||||
| controllerAddress := controllerAccount.Bech32Address(chainA.Config().Bech32Prefix) | ||||||
|
|
||||||
| chainBAccount := s.CreateUserOnChainB(ctx, testvalues.StartingTokenAmount) | ||||||
| chainBAddress := chainBAccount.Bech32Address(chainB.Config().Bech32Prefix) | ||||||
|
|
||||||
| govModuleAddress, err := s.QueryModuleAccountAddress(ctx, govtypes.ModuleName, chainA) | ||||||
| s.Require().NoError(err) | ||||||
| s.Require().NotNil(govModuleAddress) | ||||||
|
|
||||||
| t.Run("create msg submit proposal", func(t *testing.T) { | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| version := icatypes.NewDefaultMetadataString(ibctesting.FirstConnectionID, ibctesting.FirstConnectionID) | ||||||
| msgRegisterAccount := controllertypes.NewMsgRegisterInterchainAccount(ibctesting.FirstConnectionID, govModuleAddress.String(), version) | ||||||
| msgs := []sdk.Msg{msgRegisterAccount} | ||||||
| msgSubmitProposal, err := govtypesv1.NewMsgSubmitProposal(msgs, sdk.NewCoins(sdk.NewCoin(chainA.Config().Denom, govtypesv1.DefaultMinDepositTokens)), controllerAddress, "") | ||||||
| s.Require().NoError(err) | ||||||
|
|
||||||
| resp, err := s.BroadcastMessages(ctx, chainA, controllerAccount, msgSubmitProposal) | ||||||
| s.AssertValidTxResponse(resp) | ||||||
| s.Require().NoError(err) | ||||||
| }) | ||||||
|
|
||||||
| s.Require().NoError(chainA.VoteOnProposalAllValidators(ctx, "1", cosmos.ProposalVoteYes)) | ||||||
|
|
||||||
| time.Sleep(testvalues.VotingPeriod) | ||||||
| time.Sleep(5 * time.Second) | ||||||
|
|
||||||
| proposal, err := s.QueryProposalV1(ctx, chainA, 1) | ||||||
| s.Require().NoError(err) | ||||||
| s.Require().Equal(govtypesv1.StatusPassed, proposal.Status) | ||||||
|
There was a problem hiding this comment. Should we group the code between voting the proposal and checking the status in something like |
||||||
|
|
||||||
| t.Run("start relayer", func(t *testing.T) { | ||||||
| s.StartRelayer(relayer) | ||||||
| }) | ||||||
|
|
||||||
| s.Require().NoError(test.WaitForBlocks(ctx, 10, chainA, chainB)) | ||||||
|
|
||||||
| var interchainAccAddr string | ||||||
| t.Run("verify interchain account", func(t *testing.T) { | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| var err error | ||||||
| interchainAccAddr, err = s.QueryInterchainAccount(ctx, chainA, govModuleAddress.String(), ibctesting.FirstConnectionID) | ||||||
| s.Require().NoError(err) | ||||||
| s.Require().NotZero(len(interchainAccAddr)) | ||||||
|
|
||||||
| channels, err := relayer.GetChannels(ctx, s.GetRelayerExecReporter(), chainA.Config().ChainID) | ||||||
| s.Require().NoError(err) | ||||||
| s.Require().Equal(len(channels), 2) | ||||||
| }) | ||||||
|
|
||||||
| t.Run("interchain account executes a bank transfer on behalf of the corresponding owner account", func(t *testing.T) { | ||||||
| t.Run("fund interchain account wallet", func(t *testing.T) { | ||||||
| // fund the host account, so it has some $$ to send | ||||||
| err := chainB.SendFunds(ctx, ibctest.FaucetAccountKeyName, ibc.WalletAmount{ | ||||||
| Address: interchainAccAddr, | ||||||
| Amount: testvalues.StartingTokenAmount, | ||||||
| Denom: chainB.Config().Denom, | ||||||
| }) | ||||||
| s.Require().NoError(err) | ||||||
| }) | ||||||
|
|
||||||
| t.Run("create msg submit proposal", func(t *testing.T) { | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| msgBankSend := &banktypes.MsgSend{ | ||||||
| FromAddress: interchainAccAddr, | ||||||
| ToAddress: chainBAddress, | ||||||
| Amount: sdk.NewCoins(testvalues.DefaultTransferAmount(chainB.Config().Denom)), | ||||||
| } | ||||||
|
|
||||||
| cdc := testsuite.Codec() | ||||||
| bz, err := icatypes.SerializeCosmosTx(cdc, []proto.Message{msgBankSend}) | ||||||
| s.Require().NoError(err) | ||||||
|
|
||||||
| packetData := icatypes.InterchainAccountPacketData{ | ||||||
| Type: icatypes.EXECUTE_TX, | ||||||
| Data: bz, | ||||||
| Memo: "e2e", | ||||||
| } | ||||||
|
|
||||||
| msgSendTx := controllertypes.NewMsgSendTx(govModuleAddress.String(), ibctesting.FirstConnectionID, uint64(time.Hour.Nanoseconds()), packetData) | ||||||
| msgs := []sdk.Msg{msgSendTx} | ||||||
| msgSubmitProposal, err := govtypesv1.NewMsgSubmitProposal(msgs, sdk.NewCoins(sdk.NewCoin(chainA.Config().Denom, govtypesv1.DefaultMinDepositTokens)), controllerAddress, "") | ||||||
| s.Require().NoError(err) | ||||||
|
|
||||||
| resp, err := s.BroadcastMessages(ctx, chainA, controllerAccount, msgSubmitProposal) | ||||||
| s.AssertValidTxResponse(resp) | ||||||
| s.Require().NoError(err) | ||||||
| }) | ||||||
|
|
||||||
| s.Require().NoError(chainA.VoteOnProposalAllValidators(ctx, "2", cosmos.ProposalVoteYes)) | ||||||
|
|
||||||
| time.Sleep(testvalues.VotingPeriod) | ||||||
| time.Sleep(5 * time.Second) | ||||||
|
|
||||||
| proposal, err := s.QueryProposalV1(ctx, chainA, 2) | ||||||
| s.Require().NoError(err) | ||||||
| s.Require().Equal(govtypesv1.StatusPassed, proposal.Status) | ||||||
|
There was a problem hiding this comment. Similar to the previous comment: |
||||||
|
|
||||||
| t.Run("verify tokens transferred", func(t *testing.T) { | ||||||
| balance, err := chainB.GetBalance(ctx, chainBAccount.Bech32Address(chainB.Config().Bech32Prefix), chainB.Config().Denom) | ||||||
| s.Require().NoError(err) | ||||||
|
|
||||||
| _, err = chainB.GetBalance(ctx, interchainAccAddr, chainB.Config().Denom) | ||||||
| s.Require().NoError(err) | ||||||
|
|
||||||
| expected := testvalues.IBCTransferAmount + testvalues.StartingTokenAmount | ||||||
| s.Require().Equal(expected, balance) | ||||||
| }) | ||||||
| }) | ||||||
| } | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test requires a bump in the default relayer version.