chore: solomachine mock channel handshake, allow zero-height in channel handshake msgs #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… non-zero proof height in channel handshake msgs
damiannolan
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei and
chatton
as code owners
|
Left changelog section empty as this is being upstreamed to @colin-axner's branch at the moment. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## colin/1874-sm-proof-height #2776 +/- ##
==============================================================
- Coverage 78.73% 78.69% -0.04%
==============================================================
Files 178 178
Lines 12295 12283 -12
==============================================================
- Hits 9680 9666 -14
- Misses 2188 2190 +2
Partials 427 427
|
chatton
approved these changes
Nov 16, 2022
colin-axner
approved these changes
Nov 16, 2022
Comment on lines
+68
to
+70
| // close init is not necessary as the solomachine implementation is mocked | ||
|
|
||
| suite.solomachine.ChanCloseConfirm(suite.chainA, channelID) |
There was a problem hiding this comment.
If we turn the setup into a reusable func for testing receives and acks, we might want this last section to be a separate test
There was a problem hiding this comment.
I agree, I think we can do that in the next series of PRs for packet lifecycle stuff. I'll merge this to your branch now
AdityaSripal
approved these changes
Nov 16, 2022
damiannolan
deleted the
damian/2749-allow-zero-proof-height-on-chan-handshake
branch
This was referenced Nov 16, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MsgChannelOpenTryMsgChannelOpenAckMsgChannelOpenConfirmMsgChannelCloseConfirm06-solomachinecloses: #2749 #2750
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.