-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow zero proof height, solo machine discards provided proof height in favor of sequence #2746
fix: allow zero proof height, solo machine discards provided proof height in favor of sequence #2746
Changes from 12 commits
29c64f0
ed54f58
6a896cb
ed1b491
bbee84b
83a4aab
6ce6d58
75e4f51
abbaeef
07b9bf4
5087d52
36d83c2
b6dc225
2becfbf
0ed02b7
7cb3068
9d58aff
f4f8def
f07f10d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,6 +46,18 @@ func TestSoloMachineTestSuite(t *testing.T) { | |
suite.Run(t, new(SoloMachineTestSuite)) | ||
} | ||
|
||
func (suite *SoloMachineTestSuite) TestConnectionHandshake() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. when channel handshake tests are added, this func can be renamed to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't being used anywhere yet, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Currently it is acting as an integration test for setting up connections. We will use it in integration tests for setting up channels and sending/receiving packets. Currently without the fixes in this pr, main will not pass these tests (solo machine has no integration tests with core IBC and several bugs have historically slipped through because of that) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These tests couldn't be split out because they actually will fail on main (main is currently broken for solo machines) |
||
clientID := suite.solomachine.CreateClient(suite.chainA) | ||
|
||
connectionID := suite.solomachine.ConnOpenInit(suite.chainA, clientID) | ||
|
||
// open try is not necessary as the solo machine implementation is mock'd | ||
|
||
suite.solomachine.ConnOpenAck(suite.chainA, clientID, connectionID) | ||
|
||
// open confirm is not necessary as the solo machine implementation is mock'd | ||
} | ||
|
||
func (suite *SoloMachineTestSuite) GetSequenceFromStore() uint64 { | ||
bz := suite.store.Get(host.ClientStateKey()) | ||
suite.Require().NotNil(bz) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also mention relayers are must pass zero height for solomachines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relayers can pass non zero heights. Solo machine simply ignores the provided value