Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add helper fn for bank MsgSend #2732

Closed
wants to merge 27 commits into from
Closed

Conversation

charleenfei
Copy link
Contributor

Description

pending #2720


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

ctx context.Context,
controllerChain *cosmos.CosmosChain,
controllerAccount *ibc.Wallet,
msgSend banktypes.MsgSend,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can take in a sdk.Msg here so we can reuse for other msg types

@damiannolan
Copy link
Member

is this PR still relevant or should we close it? cc @charleenfei

@damiannolan
Copy link
Member

reopen if you want, doing some spring closing

@charleenfei charleenfei deleted the charly/helper_fn_ica branch December 18, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants