Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unused variables #2692

Merged
merged 6 commits into from
Nov 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/core/04-channel/keeper/handshake_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,8 @@ func (suite *KeeperTestSuite) TestChanCloseInit() {
// create channel in init
path.SetChannelOrdered()
err = path.EndpointA.ChanOpenInit()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it back and added as well asuite.Require().NoError(err)


suite.Require().NoError(err)

// ensure channel capability check passes
suite.chainA.CreateChannelCapability(suite.chainA.GetSimApp().ScopedIBCMockKeeper, path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID)
channelCap = suite.chainA.GetChannelCapability(path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID)
Expand Down
9 changes: 2 additions & 7 deletions modules/core/04-channel/keeper/packet_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,8 @@ var (
defaultTimeoutHeight = clienttypes.NewHeight(1, 100)

// for when the testing package cannot be used
clientIDA = "clientA"
clientIDB = "clientB"
connIDA = "connA"
connIDB = "connB"
portID = "portid"
channelIDA = "channelidA"
channelIDB = "channelidB"
connIDA = "connA"
connIDB = "connB"
)

// TestSendPacket tests SendPacket from chainA to chainB
Expand Down