Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: add transfer with memo compatibility tests #2640
e2e: add transfer with memo compatibility tests #2640
Changes from 2 commits
4280b4f729ad75a2fe94602f15012bd191e82ec61fab81c63722523293fc358acfbbc7File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice if in the future we can just have test exclusions, I forget why it was difficult to list all possible tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible to list all tests explicitly, the tradeoff is ease of maintenance. This syntax isn't anything we're in control of, this is the regular github action json expansion. So we can't easily add in any sort of our own logic to filter things in a certain way.
We can explicitly list an array of items, but each item has 5 or 6 properties. I would be in favour of more smaller json files focused on a specific thing even if there is some duplication rather than the long list to maintain.
In the other actions we have the concept of a test exclusion, and that's possible because we have some code that is dynamically generating the matrix that github expects. That is also always an option, to write an additional, script which has knowledge about specifics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am adding to tips of release branches here, so that we can test that transfer with memo works between
v3.4.xandv2.5.x, but I am unsure if this is supported by the e2e framework, so let's give it a try and see what happens...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I left my below comments before seeing this. This one might be tricky as the first part of the compatibility test process is building the the
release-x.y.ximage. In this case some of those images won't exist. As a work around you could launch those compatibility tests for the images that don't exist manually then cancel them after the image is built.