-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: add transfer with memo compatibility tests #2640
Merged
chatton
merged 10 commits into
main
from
carlos/add-compatibilty-test-new-minor-branches
Nov 2, 2022
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4280b4f
add transfer with memo compatibility tests
crodriguezvega 729ad75
Merge branch 'main' into carlos/add-compatibilty-test-new-minor-branches
a2fe946
add versions to dropdown
crodriguezvega 02f1501
Merge branch 'carlos/add-compatibilty-test-new-minor-branches' of htt…
crodriguezvega 2bd191e
update compatibility tests for v6.0.x
crodriguezvega 82ec61f
Merge branch 'main' into carlos/add-compatibilty-test-new-minor-branches
ab81c63
review comment
7225232
after discussion with Cian
93fc358
chore: merging with main branch
chatton acfbbc7
Merge branch 'main' into carlos/add-compatibilty-test-new-minor-branches
chatton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
.github/compatibility-test-matrices/release-v2.5.x/transfer.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "chain-a": ["release-v2.5.x", "v5.0.1", "v4.1.1", "v3.3.1", "v2.4.2"], | ||
| "chain-b": ["release-v2.5.x", "v5.0.1", "v4.1.1", "v3.3.1", "v2.4.2"], | ||
| "entrypoint": ["TestTransferTestSuite"], | ||
| "test": [ | ||
| "TestMsgTransfer_Succeeds_Nonincentivized", | ||
| "TestMsgTransfer_Fails_InvalidAddress", | ||
| "TestMsgTransfer_Timeout_Nonincentivized", | ||
| "TestMsgTransfer_WithMemo", | ||
| "TestSendEnabledParam", | ||
| "TestReceiveEnabledParam" | ||
| ], | ||
| "chain-binary": ["simd"], | ||
| "chain-image": ["ghcr.io/cosmos/ibc-go-simd"] | ||
| } | ||
15 changes: 15 additions & 0 deletions
15
.github/compatibility-test-matrices/release-v3.4.x/transfer.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "chain-a": ["release-v3.4.x", "v5.0.1", "v4.1.1", "v3.3.1", "v2.4.2"], | ||
| "chain-b": ["release-v3.4.x", "v5.0.1", "v4.1.1", "v3.3.1", "v2.4.2"], | ||
| "entrypoint": ["TestTransferTestSuite"], | ||
| "test": [ | ||
| "TestMsgTransfer_Succeeds_Nonincentivized", | ||
| "TestMsgTransfer_Fails_InvalidAddress", | ||
| "TestMsgTransfer_Timeout_Nonincentivized", | ||
| "TestMsgTransfer_WithMemo", | ||
| "TestSendEnabledParam", | ||
| "TestReceiveEnabledParam" | ||
| ], | ||
| "chain-binary": ["simd"], | ||
| "chain-image": ["ghcr.io/cosmos/ibc-go-simd"] | ||
| } |
15 changes: 15 additions & 0 deletions
15
.github/compatibility-test-matrices/release-v4.2.x/incentivized-transfer.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "chain-a": ["release-v4.2.x", "v5.0.1", "v4.1.0"], | ||
| "chain-b": ["release-v4.2.x", "v5.0.1", "v4.1.0"], | ||
| "entrypoint": ["TestIncentivizedTransferTestSuite"], | ||
| "test": [ | ||
| "TestMsgPayPacketFee_AsyncSingleSender_Succeeds", | ||
| "TestMsgPayPacketFee_InvalidReceiverAccount", | ||
| "TestMultiMsg_MsgPayPacketFeeSingleSender", | ||
| "TestMsgPayPacketFee_SingleSender_TimesOut", | ||
| "TestPayPacketFeeAsync_SingleSender_NoCounterPartyAddress", | ||
| "TestMsgPayPacketFee_AsyncMultipleSenders_Succeeds" | ||
| ], | ||
| "chain-binary": ["simd"], | ||
| "chain-image": ["ghcr.io/cosmos/ibc-go-simd"] | ||
| } |
15 changes: 15 additions & 0 deletions
15
.github/compatibility-test-matrices/release-v4.2.x/transfer.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "chain-a": ["release-v4.2.x", "v5.0.1", "v4.1.1", "v3.3.1", "v2.4.2"], | ||
| "chain-b": ["release-v4.2.x", "v5.0.1", "v4.1.1", "v3.3.1", "v2.4.2"], | ||
| "entrypoint": ["TestTransferTestSuite"], | ||
| "test": [ | ||
| "TestMsgTransfer_Succeeds_Nonincentivized", | ||
| "TestMsgTransfer_Fails_InvalidAddress", | ||
| "TestMsgTransfer_Timeout_Nonincentivized", | ||
| "TestMsgTransfer_WithMemo", | ||
| "TestSendEnabledParam", | ||
| "TestReceiveEnabledParam" | ||
| ], | ||
| "chain-binary": ["simd"], | ||
| "chain-image": ["ghcr.io/cosmos/ibc-go-simd"] | ||
| } |
15 changes: 15 additions & 0 deletions
15
.github/compatibility-test-matrices/release-v5.1.x/incentivized-transfer.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "chain-a": ["release-v5.1.x", "v5.0.1", "v4.1.1"], | ||
| "chain-b": ["release-v5.1.x", "v5.0.1", "v4.1.1"], | ||
| "entrypoint": ["TestIncentivizedTransferTestSuite"], | ||
| "test": [ | ||
| "TestMsgPayPacketFee_AsyncSingleSender_Succeeds", | ||
| "TestMsgPayPacketFee_InvalidReceiverAccount", | ||
| "TestMultiMsg_MsgPayPacketFeeSingleSender", | ||
| "TestMsgPayPacketFee_SingleSender_TimesOut", | ||
| "TestPayPacketFeeAsync_SingleSender_NoCounterPartyAddress", | ||
| "TestMsgPayPacketFee_AsyncMultipleSenders_Succeeds" | ||
| ], | ||
| "chain-binary": ["simd"], | ||
| "chain-image": ["ghcr.io/cosmos/ibc-go-simd"] | ||
| } |
15 changes: 15 additions & 0 deletions
15
.github/compatibility-test-matrices/release-v5.1.x/transfer.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "chain-a": ["release-v5.1.x", "v5.0.1", "v4.1.1", "v3.3.1", "v2.4.2"], | ||
| "chain-b": ["release-v5.1.x", "v5.0.1", "v4.1.1", "v3.3.1", "v2.4.2"], | ||
| "entrypoint": ["TestTransferTestSuite"], | ||
| "test": [ | ||
| "TestMsgTransfer_Succeeds_Nonincentivized", | ||
| "TestMsgTransfer_Fails_InvalidAddress", | ||
| "TestMsgTransfer_Timeout_Nonincentivized", | ||
| "TestMsgTransfer_WithMemo", | ||
| "TestSendEnabledParam", | ||
| "TestReceiveEnabledParam" | ||
| ], | ||
| "chain-binary": ["simd"], | ||
| "chain-image": ["ghcr.io/cosmos/ibc-go-simd"] | ||
| } |
5 changes: 3 additions & 2 deletions
5
.github/compatibility-test-matrices/release-v6.0.x/transfer.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice if in the future we can just have test exclusions, I forget why it was difficult to list all possible tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible to list all tests explicitly, the tradeoff is ease of maintenance. This syntax isn't anything we're in control of, this is the regular github action json expansion. So we can't easily add in any sort of our own logic to filter things in a certain way.
We can explicitly list an array of items, but each item has 5 or 6 properties. I would be in favour of more smaller json files focused on a specific thing even if there is some duplication rather than the long list to maintain.
In the other actions we have the concept of a test exclusion, and that's possible because we have some code that is dynamically generating the matrix that github expects. That is also always an option, to write an additional, script which has knowledge about specifics.